Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

wiki: Ensure wiki page not found gives a 404. #699

Closed
wants to merge 2 commits into from
Closed

wiki: Ensure wiki page not found gives a 404. #699

wants to merge 2 commits into from

Conversation

andre-d
Copy link
Contributor

@andre-d andre-d commented Feb 22, 2013

Fixes #657 and #658

@andre-d
Copy link
Contributor Author

andre-d commented Feb 22, 2013

Updated to fix #658

spladug
spladug reviewed Mar 21, 2013
View reviewed changes
r2/r2/controllers/wiki.py
if c.render_style in extensions.API_TYPES:
self.handle_error(404, 'PAGE_NOT_CREATED')
return WikiNotFound(page=page_name).render()
api = c.render_style in extensions.API_TYPES
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about is_api for the variable name?

@spladug
Copy link
Contributor

spladug commented Mar 21, 2013

💅

@andre-d
Copy link
Contributor Author

andre-d commented May 8, 2013

💇

@spladug
Copy link
Contributor

spladug commented May 9, 2013

🐟

@andre-d
Copy link
Contributor Author

andre-d commented May 13, 2013

2e36cab

@andre-d andre-d closed this May 13, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@andre-d @spladug